Repository navigation
[SYCL] Suppress internal deprecation warnings in headers - #23589
Open
jakubxstepnowski wants to merge 12 commits into
Open
jakubxstepnowski wants to merge 12 commits into
jakubxstepnowski wants to merge 12 commits into
Conversation
Suppress internal deprecation warnings in SYCL headers when the include directory is specified with -I, as discussed in: intel#22038.
Suppress internal deprecation warnings in SYCL headers when the include directory is specified with -I, as discussed in: intel#22038.
Wraps all deprecated features used in header files in: __SYCL_SUPPRESS_DEPRECATED_PUSH/POP and adds comments which features are deprecated inside such block. fixes issue: intel#22038.
Fix include formatting in reduction and span headers.
Remove the unused detail helpers isTargetHostAccess and modeNeedsOldData from access.hpp. In fragment.hpp, replace the deprecated this_sub_group() with get_sub_group() and drop the suppression.
Contributor
Author
|
Hi @intel/llvm-reviewers-runtime could you please review this PR? |
Formats header includes and removes some unnecessary spacing around __SYCL_SUPPRESS_DEPRECATED_PUSH/POP
This reverts commit 37f26f5. Tried to enforce nicer formatting, did not pass CI.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suppress internal deprecation warnings in SYCL headers when the include directory is specified with -I,
as discussed in: #22038.